Skip to content
Snippets Groups Projects

merge Power tube power to main

Merged merge Power tube power to main
PowerTubePower into main
2 unresolved threads
Merged Nicolai Grarup Lauest requested to merge PowerTubePower into main
2 unresolved threads

please check if more tests are needed for the powertube constructor

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Microwave.Classes/Boundary/PowerTube.cs
8 private IOutput myOutput;
9
10 private bool IsOn = false;
11
12 private readonly int powerTubeSize;
13
14 public int PowerTubeSize
15 {
16 get { return powerTubeSize; }
17 }
18
19 public PowerTube(IOutput output, int powerTubeSize)
20 {
21 myOutput = output;
22 this.powerTubeSize =( powerTubeSize == 500 | powerTubeSize == 700 | powerTubeSize == 800 | powerTubeSize == 1000
23 ? powerTubeSize : 500);
  • Jonas Alexander Landsfeldt
    Jonas Alexander Landsfeldt @au682401 started a thread on the diff
    • Microwave.Test.Unit/PowerTubeTest.cs
    16 16 public void Setup()
    17 17 {
    18 18 output = Substitute.For<IOutput>();
    19 uut = new PowerTube(output);
    19 uut = new PowerTube(output,700);
    20 20 }
    21 21
    22 [TestCase(1)]
    22
    23
    24 [TestCase(1)]
    23 25 [TestCase(50)]
    24 26 [TestCase(100)]
    25 27 [TestCase(699)]
    26 28 [TestCase(700)]
    27 29 public void TurnOn_WasOffCorrectPower_CorrectOutput(int power)
    • Jonas Alexander Landsfeldt
      Jonas Alexander Landsfeldt @au682401 ·
      Owner

      Måske der skal testes med maxværdi også, så 1000 og 1001. Samme for den efterfølgende test.

      Suggested change
      29 public void TurnOn_WasOffCorrectPower_CorrectOutput(int power)
      29 [TestCase(1000)]
      30 public void TurnOn_WasOffCorrectPower_CorrectOutput(int power)
    • Please register or sign in to reply
  • Jonas Alexander Landsfeldt
    Jonas Alexander Landsfeldt @au682401 ·
    Owner

    100% coverage med nuværende test - lige et enkelt sted testen kan udvides

  • Nicolai Grarup Lauest mentioned in commit 1cb032dc

    mentioned in commit 1cb032dc

  • Nicolai Grarup Lauest merged

    merged

    • Please register or sign in to reply